Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport 3945 to .16 #3948

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Aug 27, 2020

Backport #3945 to .16 release.

Proposed Changes

  • Check the length of the branches and if they change, realloc the array of BranchStatuses. Otherwise, if branches are added, panic happens.

Release Note

- 🐛 Fix bug
If you create a Parallel, then later add branches to it, caused a panic.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 27, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
@knative-prow-robot knative-prow-robot merged commit c6f3501 into knative:release-0.16 Aug 27, 2020
@vaikas vaikas deleted the backport-3945-to-16 branch August 27, 2020 21:30
matzew pushed a commit to matzew/eventing that referenced this pull request Sep 30, 2020
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 1, 2020
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Oct 7, 2020
* adding istion annotation (knative#3534) (knative#3557)

* adding istion annotation (knative#3534)

* backporting knative#3543

* Update test/lib/duck/resource_inspectors.go

Co-authored-by: Matt Moore <mattmoor@vmware.com>

* Use the standard resource creation libs for upgrade tests. (knative#3539)

* try to dump some state

* use client wait or fail

* create broker directly

* removed the unused import

Co-authored-by: Matt Moore <mattmoor@vmware.com>

* cp 3897 (knative#3902)

* cp 3897

* backport 3719

* x bit

* apiserversource v1beta1->v1alpha2

* install broker / sugar

* backport 3945 to .16 (knative#3948)

Co-authored-by: VijayaSenaReddy Ayyappaneni <48216363+vayyappaneni@users.noreply.github.com>
Co-authored-by: Matt Moore <mattmoor@vmware.com>
Co-authored-by: Ville Aikas <11279988+vaikas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants